Skip to content

fix: failed signup attempt with anonymous ParseUser leaves it in inconsistent state #1136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 10, 2021
Merged

fix: failed signup attempt with anonymous ParseUser leaves it in inconsistent state #1136

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5327b35
fix: make sure to not clobber state["authData"] with values if saving…
shlusiak Oct 27, 2021
aba063d
Merge branch 'master' into 401-fix-authdata-clobbering-in-putAuthData
mtrezza Nov 9, 2021
4bc9067
fix: failing tests after change to authData
shlusiak Nov 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions parse/src/main/java/com/parse/ParseUser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -757,15 +757,15 @@ private Map<String, String> getAuthData(String authType) {

/* package */ void putAuthData(String authType, Map<String, String> authData) {
synchronized (mutex) {
Map<String, Map<String, String>> newAuthData = getAuthData();
Map<String, Map<String, String>> newAuthData = new HashMap<>(getAuthData());
newAuthData.put(authType, authData);
performPut(KEY_AUTH_DATA, newAuthData);
}
}

private void removeAuthData(String authType) {
synchronized (mutex) {
Map<String, Map<String, String>> newAuthData = getAuthData();
Map<String, Map<String, String>> newAuthData = new HashMap<>(getAuthData());
newAuthData.remove(authType);
performPut(KEY_AUTH_DATA, newAuthData);
}
Expand Down