Periodic checkpoint generation #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
branylagaffe
suggested changes
Jul 24, 2024
Contributor
branylagaffe
left a comment
branylagaffe
left a comment
There was a problem hiding this comment.
I am convinced that using QEMU and the HMP command are a good way to trigger (qemu snapshot and) flexus checkpoint dump.
However, I don't think using a REAL_CLOCK timer is a good solution. KeenKraken and KnottyKraken use icount, which counts instructions. Creating a timer based on icount is maybe a better solution.
| flexus_ckpt_timer = NULL; // Reset the timer pointer | ||
| } | ||
|
|
||
| FlexusCkptData *data = g_malloc(sizeof(FlexusCkptData)); |
Contributor
There was a problem hiding this comment.
Good 'Ol memory leak ?
Contributor
There was a problem hiding this comment.
Any reason why this cannot be a global variable ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.