Search in chat #394

untreu2 · 2025-07-23T13:43:09Z

Description

The "Search in Chat" feature has been added in accordance with the designs.

Type of Change

✨ New feature (non-breaking change which adds functionality)
🛠️ Bug fix (non-breaking change which fixes an issue)
❌ Breaking change (fix or feature that would cause existing functionality to change)
🧹 Code refactor
✅ Build configuration change
📝 Documentation
🗑️ Chore

Checklist

Run just precommit to ensure that formatting and linting are correct
Updated the CHANGELOG.md file with your changes

josefinalliende

Really cool feature! Huge job! 🚀 I still have to try it locally but left some comments/doubts in the meantime

josefinalliende · 2025-07-23T14:30:59Z

lib/ui/chat/chat_info/dm_chat_info.dart

+                visualState: AppButtonVisualState.secondary,
+                icon: const Text('Search Chat'),
+                label: SvgPicture.asset(
+                  AssetsPaths.icSearch,


I have a doubt.. there is a carbon icons package that has the same icons that Figma design. Is there a reason to have them downloaded as svgs?

Its seems confusing to me that the icon prop receives the text and that the label prop receives the icon...

I did this because of the position of the icon and label. This is more of a discussion about app button widget. So I'll leave it as it is for now.

As for the SVG issue, I used the assets folder so that we could make changes to them from a single location in the future. I think @Quwaysim created the assets folder.

So, should all CarbonIcons be replaced with SVGs from the assets folder? I like the CarbonIcons syntax, t’s easy to read and makes it simple to match icon names with Figma. That said, maybe SVGs work better in Flutter? Or are there any drawbacks to using CarbonIcons? Happy to chat more about it on Thursday to make sure we're on the same page.

Related to the app button widget .. Would it be okay if I open a small issue to suggest adding something like an iconPosition prop to the button? Just to make it clearer whether the icon is on the left or right—so we don't have to swap prop values like in this case.

Yeah, It’d be good for sure.

I'll open the issue then! 😄

lib/config/providers/chat_search_provider.dart

Simplifies the loop for finding query matches in message content by using a single variable for match index and updating it within the loop. This improves readability and ensures correct handling of overlapping matches.

josefinalliende

I tried to help with the rebase due to the conflicts cause of my PR that renames components. Hope it helps!

josefinalliende · 2025-07-23T16:19:05Z

lib/ui/chat/chat_info/dm_chat_info.dart

                ],
              ),
              Gap(32.h),
+              AppFilledButton.icon(


Just to help with the rebase: this one is now called WnFilledButton

josefinalliende · 2025-07-23T16:19:29Z

lib/ui/chat/chat_info/dm_chat_info.dart

              ),
              Gap(32.h),
+              AppFilledButton.icon(
+                size: AppButtonSize.small,


same, to help with the rebase: this one is now called WnButtonVisualState

josefinalliende · 2025-07-23T16:19:47Z

lib/ui/chat/chat_info/dm_chat_info.dart

+              ),
+
+              Gap(12.h),
              AppFilledButton.icon(


same, to help with the rebase: this one is now called WnFilledButton

josefinalliende · 2025-07-23T16:19:58Z

lib/ui/chat/chat_info/dm_chat_info.dart

+
+              Gap(12.h),
              AppFilledButton.icon(
                size: AppButtonSize.small,


same, to help with the rebase: this one is now called WnButtonSize

josefinalliende · 2025-07-23T16:20:16Z

lib/ui/chat/chat_screen.dart

-                              }
+                        // Only show AppBar when search is not active
+                        if (!searchState.isSearchActive)
+                          CustomAppBar.sliver(


same, to help with the rebase: this one is now called WnAppBar

josefinalliende

I tried it locally and loved it 😍 . Just a couple of small feedback (totally fine to address in a future PR—I just wanted to share them so we don’t forget):

The color of the match count looks white, but in Figma it seems to be muted.

Captura de pantalla 2025-07-23 a la(s) 6 41 49 p m

Messages without a match don’t appear transparent—they look like regular messages. Not sure if that’s intentional, but I think adding some transparency might help make it clearer when a message doesn't contain a match.

Without match on first message	❓ With match in first message ✅

untreu2 · 2025-07-23T22:47:00Z

I tried it locally and loved it 😍 . Just a couple of small feedback (totally fine to address in a future PR—I just wanted to share them so we don’t forget):

The color of the match count looks white, but in Figma it seems to be muted.

Messages without a match don’t appear transparent—they look like regular messages. Not sure if that’s intentional, but I think adding some transparency might help make it clearer when a message doesn't contain a match.

|Without match on first message| ❓ With match in first message ✅ |

|----|----|

|||

|||

Thanks for the feedback! Noted.

untreu2 added 6 commits July 23, 2025 11:56

Add Search Chat button

3f0db31

Add search in chat feature

3f3608b

Remove bold styling from search matches in messages

98a6f20

Hide msg input field when search is on

f8ea222

Add TODO comment

0080108

Just format

958975c

josefinalliende self-requested a review July 23, 2025 13:55

untreu2 requested review from Quwaysim and codeswot July 23, 2025 13:57

josefinalliende reviewed Jul 23, 2025

View reviewed changes

untreu2 added 2 commits July 23, 2025 18:36

Refactor chat search match indexing logic

fd2fa7d

Simplifies the loop for finding query matches in message content by using a single variable for match index and updating it within the loop. This improves readability and ensures correct handling of overlapping matches.

Just format

d9bdff0

josefinalliende reviewed Jul 23, 2025

View reviewed changes

josefinalliende mentioned this pull request Jul 23, 2025

Add icon position arg to buttons #395

Closed

untreu2 force-pushed the search-in-chat branch from a388b53 to d9bdff0 Compare July 23, 2025 22:03

untreu2 added 2 commits July 24, 2025 01:09

Merge branch 'master' into search-in-chat

7af1fac

Just format

5a30bd8

josefinalliende self-requested a review July 23, 2025 22:42

josefinalliende approved these changes Jul 23, 2025

View reviewed changes

untreu2 merged commit cb3e44f into master Jul 23, 2025
1 check passed

untreu2 deleted the search-in-chat branch July 25, 2025 14:03

Search in chat #394

Search in chat #394

Uh oh!

Conversation

untreu2 commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of Change

Checklist

Uh oh!

josefinalliende left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

josefinalliende left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

josefinalliende left a comment

Choose a reason for hiding this comment

Uh oh!

untreu2 commented Jul 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

untreu2 commented Jul 23, 2025 •

edited

Loading