Refactor/components prefix #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
codeswot
reviewed
Jul 23, 2025
lib/main.dart
Outdated
| import 'package:whitenoise/routing/router_provider.dart'; | ||
| import 'package:whitenoise/src/rust/frb_generated.dart'; | ||
| import 'package:whitenoise/ui/core/ui/toast_widget.dart'; | ||
| import 'package:whitenoise/ui/core/ui/wn_toast_wrapper.dart'; |
Contributor
There was a problem hiding this comment.
this was renamed to 'wn_toast_wrapper' from 'toast_widget' can it be 'wn_toast' basically the content (classes) in the file are all widgets but not all wrappers. so lets not call the file with suffix of wrapper
Contributor
Author
There was a problem hiding this comment.
Thanks for the feedback! I'll rename it!
Contributor
Author
There was a problem hiding this comment.
now it's renamed to just WnToast ✅
josefinalliende
force-pushed
the
refactor/components-prefix
branch
3 times, most recently
from
782cdcc to
8b8bfd3
Compare
…o WnValidationNotification
josefinalliende
force-pushed
the
refactor/components-prefix
branch
from
8b8bfd3 to
888afd6
Compare
codeswot
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We had several widgets in the core/ui folder with inconsistent prefixes: some started with App, others with Custom or Whitenoise, and a few had no prefix at all.
To improve naming consistency, we decided to standardize them using the Wn prefix (short for WhiteNoise — the full name felt too long).
This PR:
w_n_button.dartlooked a bit odd.I ran the app locally and everything seems to be working fine on my end, but I’d appreciate it if in the review you could check it locally as well, just in case I missed something.
Type of Change
Checklist
just precommitto ensure that formatting and linting are correctCHANGELOG.mdfile with your changes