Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add onboard_as_parachain flag to parachain options #886

Merged
merged 17 commits into from
Apr 6, 2023
Merged

Add onboard_as_parachain flag to parachain options #886

merged 17 commits into from
Apr 6, 2023

Conversation

antonva
Copy link
Contributor

@antonva antonva commented Apr 3, 2023 •
edited
Loading

This option effectively exposes the parachain boolean parameter from paraSudoWrapper.sudoScheduleParaInitialize. Exposing the option allows Zombienet to provision parathreads.

The default behaviour remains the same but a parachain defined with onboard_as_parachain = false will register the para without upgrading/onboarding it to the parachain lifecycle.

Example:

[[parachains]]
id = 100
add_to_genesis = false
register_para = true
onboard_as_parachain = false

  [parachains.collator]
  name = "collator01"
  #...

antonva and others added 2 commits April 3, 2023 10:45
@antonva @wirednkod
Update javascript/packages/orchestrator/src/configGenerator.ts
2e64ac4 
Co-authored-by: Nikos Kontakis <wirednkod@gmail.com>
@antonva
Fix typo
c0d24c1
@antonva
Copy link
Contributor Author

antonva commented Apr 3, 2023

Not really sure why the lint jobs are failing in CI. Not getting the same error locally when running npm run lint

@wirednkod
Copy link
Contributor

wirednkod commented Apr 3, 2023 •
edited
Loading

Not really sure why the lint jobs are failing in CI. Not getting the same error locally when running npm run lint

Can you try running inside javascript dir the command: yarn run lint:write and then push all your changes?

wirednkod
wirednkod approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@wirednkod wirednkod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

pepoviola
pepoviola reviewed Apr 3, 2023
View reviewed changes
Copy link
Collaborator

@pepoviola pepoviola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @antonva!! looks good, a couple of comment mostly about using camelCase in naming and the default value.

Thanks!

antonva and others added 5 commits April 3, 2023 11:23
@l0r1s l0r1s self-requested a review April 3, 2023 13:35
antonva and others added 2 commits April 3, 2023 14:48
@antonva @l0r1s
Apply suggestions from code review
ea94b2c 
Co-authored-by: Loris Moulin <45130584+l0r1s@users.noreply.github.com>
@antonva
Run linter on code review changes
441a38a
@wirednkod wirednkod requested a review from pepoviola April 3, 2023 16:26
@pepoviola pepoviola merged commit 4bc7a11 into main Apr 6, 2023
@pepoviola pepoviola deleted the antonva/onboard-parachains-flag branch April 6, 2023 11:11
@pepoviola
Copy link
Collaborator

Merged, thanks @antonva!

@antonva
Copy link
Contributor Author

antonva commented Apr 6, 2023

Wonderful, thanks for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepoviola pepoviola pepoviola approved these changes

@wirednkod wirednkod wirednkod approved these changes

@l0r1s l0r1s l0r1s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@antonva @wirednkod @pepoviola @l0r1s