remove env var from image, to allow other to use easily (#1207)

* remove env var from image, to allow other to use easily

* add env var in ci

.gitlab-ci.yml

@@ -23,6 +23,7 @@ variables:
   IMAGE_NAME: $DOCKERHUB_REPO/zombienet
   BUILDAH_IMAGE: "quay.io/buildah/stable:v1.29"
   BUILDAH_COMMAND: "buildah --storage-driver overlay2"
+  RUN_IN_CONTAINER: "1"
 
 .kubernetes-env: &kubernetes-env
   image: $CI_IMAGE
@@ -279,4 +280,4 @@ db-snapshot:
   script:
     - /home/nonroot/zombie-net/scripts/ci/run-test-local-env-manager.sh
       --local-dir="${LOCAL_DIR}"
-      --test="0013-db-snapshot.zndsl"
+      --test="0013-db-snapshot.zndsl"

scripts/ci/docker/zombienet_builder.Dockerfile

@@ -72,8 +72,6 @@ RUN mkdir -p /etc/zombie-net
 RUN chown -R nonroot. /etc/zombie-net
 
 # Use the non-root user to run our application
-# Tell run test script that it runs in container
-ENV RUN_IN_CONTAINER 1
 USER nonroot
 # Tini allows us to avoid several Docker edge cases, see https://github.com/krallin/tini.
 ENTRYPOINT ["tini", "--", "bash"]

scripts/ci/docker/zombienet_injected.Dockerfile

@@ -57,8 +57,6 @@ RUN mkdir -p /etc/zombie-net
 RUN chown -R nonroot. /etc/zombie-net
 
 # Use the non-root user to run our application
-# Tell run test script that it runs in container
-ENV RUN_IN_CONTAINER 1
 USER nonroot
 # Tini allows us to avoid several Docker edge cases, see https://github.com/krallin/tini.
 ENTRYPOINT ["tini", "--", "bash"]