-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies to support tokio 0.3 #38
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AgeManning. Any objections to any of these newer versions?
futures_codec = { version = "0.4", optional = true } | ||
tokio-util = { version = "0.3.1", features = ["codec"], optional = true } | ||
nom = { version = "5", optional = true } | ||
bytes = { version = "0.5.6", optional = true } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bytes = { version = "0.5.6", optional = true } | |
bytes = { version = "0.6.0", optional = true } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recall there being a conflict with this, and I had to specifically downgrade it.
Does this update still compile? If so, lets add it in
Co-authored-by: Max Inden <mail@max-inden.de>
Co-authored-by: Max Inden <mail@max-inden.de>
Sorry, I messed up with the feature selection when testing this locally. Feel free to revert or wait for the upstream changes. |
This is a trivial update. I'm currently using a local version for my tokio 0.3 needs. I'll let you guys update in your own time. :) |
Overview
This PR updates dependencies to support the tokio 0.3 framework. Specifically the tokio-util crate.