Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to support tokio 0.3 #38

Closed
wants to merge 4 commits into from

Conversation

AgeManning
Copy link

Overview

This PR updates dependencies to support the tokio 0.3 framework. Specifically the tokio-util crate.

Copy link
Contributor

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AgeManning. Any objections to any of these newer versions?

futures_codec = { version = "0.4", optional = true }
tokio-util = { version = "0.3.1", features = ["codec"], optional = true }
nom = { version = "5", optional = true }
bytes = { version = "0.5.6", optional = true }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
bytes = { version = "0.5.6", optional = true }
bytes = { version = "0.6.0", optional = true }

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recall there being a conflict with this, and I had to specifically downgrade it.

Does this update still compile? If so, lets add it in

Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
AgeManning and others added 2 commits November 3, 2020 17:03
Co-authored-by: Max Inden <mail@max-inden.de>
Co-authored-by: Max Inden <mail@max-inden.de>
@mxinden
Copy link
Contributor

mxinden commented Nov 3, 2020

I recall there being a conflict with this, and I had to specifically downgrade it.

Sorry, I messed up with the feature selection when testing this locally. futures-codec v0.4.1 depends on bytes v0.5.6. An update is proposed in matthunz/futures-codec#51 but not yet released.

Feel free to revert or wait for the upstream changes.

@AgeManning
Copy link
Author

This is a trivial update.

I'm currently using a local version for my tokio 0.3 needs. I'll let you guys update in your own time. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants