Skip to content

Conversation

@alexggh
Copy link
Contributor

@alexggh alexggh commented Jul 11, 2025

Somehow, because cargo build is using the local reference of hashdb, cargo build did not complain about:

error[E0277]: `S` cannot be shared between threads safely
   --> src/lib.rs:604:3
    |
604 |         self
    |         ^^^^ `S` cannot be shared between threads safely

But cargo publish is using the crates.io version and in that case we get the above errors, not completely sure why the local crate makes a difference, but I just fixed it.

Additionally, also set the default-features to true for foldhash, so that no_std build in polkadot-sdk works.

Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
@alexggh alexggh requested review from bkchr, lexnv and skunert July 11, 2025 09:45
@alexggh alexggh merged commit f43bc12 into master Jul 11, 2025
4 checks passed
@michalkucharczyk
Copy link
Contributor

michalkucharczyk commented Aug 11, 2025

Was this already released as memory-db 0.34.0 (likely with #224)? If yes could we have a tag please (could not found it)?

@alexggh
Copy link
Contributor Author

alexggh commented Aug 27, 2025

Was this already released as memory-db 0.34.0 (likely with #224)? If yes could we have a tag please (could not found it)?

Sorry, forgot to push the tag it is memory-db-v0.34.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants