Inline value should never be recorded. #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
approved these changes
Feb 13, 2023
trie-db/src/lookup.rs
Outdated
| if value_recording_required { | ||
| let is_inline = L::MAX_INLINE_VALUE | ||
| .map(|max| data.as_ref().len() < max as usize) | ||
| .unwrap_or(true); |
There was a problem hiding this comment.
Suggested change
| .unwrap_or(true); | |
| .unwrap_or(false); |
There was a problem hiding this comment.
It's true I think: if No inline limit, then this is the old trie version where all values are inline so is_inline should be true for MAX_INLINE_VALUE I think (I allways end up needing to think twice here).
There was a problem hiding this comment.
Ahh okay. This is really confusing. Could you please leave some comment?
There was a problem hiding this comment.
added, also inverse the comparison order (seems more readable this way).
was my morning plan 👍 |
cheme
commented
Feb 14, 2023
| @@ -452,7 +452,7 @@ fn test_recorder_with_cache_get_hash_internal<T: TrieLayout>() { | |||
| assert!(cache.get_node(&root).is_some()); | |||
| // Also the data should be cached. | |||
|
|
|||
| if T::MAX_INLINE_VALUE.map_or(true, |l| l as usize >= key_value[1].1.len()) { | |||
| if T::MAX_INLINE_VALUE.map_or(true, |l| l as usize > key_value[1].1.len()) { | |||
There was a problem hiding this comment.
this test was not correct
arkpar
approved these changes
Feb 14, 2023
|
Will release as 0.25.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When value are inline, they are encoded into their parent node and we shall not record them individually.
Should fix: paritytech/substrate#13357