Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

substrate runner: increase line read + dump CLI output if parsing fails #1781

Merged
merged 14 commits into from
Sep 24, 2024
Merged

substrate runner: increase line read + dump CLI output if parsing fails #1781

merged 14 commits into from
Sep 24, 2024

Conversation

niklasad1
Copy link
Member

No description provided.

@niklasad1 niklasad1 requested a review from a team as a code owner September 23, 2024 08:18
jsdw
jsdw approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice: hopefully that'll make it easier to debug failures!

@niklasad1 niklasad1 changed the title substrate runner: dump CLI output parsing fails substrate runner: increase line readering + dump CLI output if parsing fails Sep 23, 2024
@niklasad1 niklasad1 changed the title substrate runner: increase line readering + dump CLI output if parsing fails substrate runner: increase line read + dump CLI output if parsing fails Sep 23, 2024
niklasad1
niklasad1 commented Sep 24, 2024
View reviewed changes
testing/substrate-runner/src/lib.rs
@@ -301,7 +304,43 @@ fn try_find_substrate_port_from_output(
.unwrap_or_else(|_| panic!("valid port expected for log line, got '{port_str}'"));
p2p_port = Some(port_num);
}

if port.is_some() && p2p_address.is_some() && p2p_port.is_some() {
Copy link
Member Author

@niklasad1 niklasad1 Sep 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bail early if we found our ports

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooh good catch!

@niklasad1 niklasad1 merged commit 9db5a39 into master Sep 24, 2024
13 checks passed
@niklasad1 niklasad1 deleted the na-substrate-runner-print-log-if-failed branch September 24, 2024 13:33
@niklasad1 niklasad1 mentioned this pull request Sep 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsdw jsdw jsdw approved these changes

@lexnv lexnv lexnv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@niklasad1 @jsdw @lexnv