This repository was archived by the owner on Nov 15, 2023. It is now read-only.
clean the interface of supports map #9674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kianenigma
added
A0-please_review
kianenigma
changed the title
19 tasks
shawntabrizi
approved these changes
Sep 2, 2021
|
bot merge |
|
Waiting for commit status. |
|
Merge aborted: Checks failed for 0eac45d |
|
bot merge |
|
Waiting for commit status. |
|
Merge aborted: Checks failed for 0eac45d |
|
Jesus, finally I can merge this. The CI has been super flaky today. |
|
bot merge |
|
Trying merge. |
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans some legacy code. We remove the complicated trait that allowed both
SupportsandSupportMapto have the sameimpl Evaluate. The former is never needs to be evaluated anyhow.Almost certainly insubstantial. The only real code that is being changed is a few less checks in
fn feasibility_check, but I strongly assert that all of the removed check were totally redundant. I invite any reviewer to challenge about that.