This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Refactor codec implementation for header #9489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gui1117
added
A0-please_review
bkchr
approved these changes
Aug 3, 2021
|
bot merge force |
|
Trying merge. |
|
Merge failed: "7 of 8 required status checks are expected. At least 2 approving reviews are required by reviewers with write access." |
19 tasks
ascjones
approved these changes
Aug 3, 2021
|
bot merge |
|
Trying merge. |
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currenctly codec is manually implemented, but the derive macro implement it just fine.
This PR add a regression test which test that the encoding has not changed. the test has been executed before and after the codec change.