This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Run cargo fmt on infrequently updated source files
#9381
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expenses
added
A2-insubstantial
expenses
added
the
D3-trivial 🧸
gilescope
reviewed
Jul 19, 2021
| tree.import("A", 1, (), &is_descendent_of), | ||
| Err(Error::Revert), | ||
| ); | ||
| assert_eq!(tree.import("A", 1, (), &is_descendent_of), Err(Error::Revert),); |
There was a problem hiding this comment.
I thought the commas are set to be Vertical so this last comma should not be there? ,
There was a problem hiding this comment.
(aside from the single line additional commas the rest looks parity coding standard to me.)
|
Can we please either do all at once or do it over time via normal pull requests. IMO we should not start creating individual prs to run cargo fmt on them. |
Okay, that's fair. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #8982, we can start running
cargo fmton the source code. In order to be less disruptive to PRs that are currently underway, I figured that we could start with source files that aren't updated very frequently (or at least, ones that were last updated more than 14 days ago).This PR contains no logic changes and is just the result of me running
cargo +nightly fmt.