This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
make SelectChain async #9128
Merged
make SelectChain async #9128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresilva
added
A0-please_review
andresilva
force-pushed
the
andre/async-select-chain
branch
from
e25e1d8
to
b227aed
Compare
bkchr
approved these changes
Jun 16, 2021
andresilva
added
the
D3-trivial 🧸
|
bot merge |
|
Trying merge. |
|
Bot will approve on the behalf of @andresilva, since they are a team lead, in an attempt to reach the minimum approval count |
ghost
merged commit 
ghost
approved these changes
Jun 20, 2021
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be required for Polkadot as we'll need a custom
SelectChainthat queries some subsystems (asynchronously). Also madeJustificationImportasync in the process.polkadot companion: paritytech/polkadot#3268