Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Update the Grafana dashboards #8832

Merged
2 commits merged into from
May 20, 2021
Merged

Update the Grafana dashboards #8832

2 commits merged into from
May 20, 2021

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented May 17, 2021

Updates the dashboards to the latest changes that I've made over the past weeks.

As usual it's kind of hard to review if you're trying to read JSON, so I guess trust me that I haven't done anything wrong 🤷

@tomaka tomaka added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels May 17, 2021
@tomaka tomaka requested a review from a team as a code owner May 17, 2021 09:37
Copy link

@lovelaced lovelaced left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a few specific node names in here which should either be removed or generalized in some way.

@tomaka
Copy link
Contributor Author

tomaka commented May 17, 2021

There were panels on top showing the node name, and apparently Grafana's export feature doesn't understand that the values come from a variable.
Removed them.

@adoerr adoerr self-requested a review May 17, 2021 15:20
@tomaka
Copy link
Contributor Author

tomaka commented May 20, 2021

bot merge

@ghost
Copy link

ghost commented May 20, 2021

Trying merge.

@ghost ghost merged commit 1d7f6e1 into paritytech:master May 20, 2021
@tomaka tomaka deleted the prometheus-update branch May 20, 2021 08:34
nazar-pc pushed a commit to autonomys/substrate that referenced this pull request Aug 8, 2021
* Update the Grafana dashboards

* Remove the panels on top
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants