Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Add PolkaFoundry, PolkaSmith SS58 address #8623

Merged
merged 6 commits into from
Jun 23, 2021
Merged

Add PolkaFoundry, PolkaSmith SS58 address #8623

merged 6 commits into from
Jun 23, 2021

Conversation

thanhtung6824
Copy link
Contributor

@thanhtung6824 thanhtung6824 commented Apr 15, 2021 •
edited
Loading

This PR adds an account prefix for PolkaFoundry, PolkaSmith network.

Github: https://github.com/polkafoundry/newpolka
Website: https://polkafoundry.com/

@thanhtung6824
Copy link
Contributor Author

Hi @BenWhiteJam. Could you review it?

@BenWhiteJam
Copy link

@thanhtung6824 can you please reach out in Element?

@cla-bot-2021
Copy link

cla-bot-2021 bot commented May 7, 2021

User @thanhtung6824, please sign the CLA here.

BenWhiteJam
BenWhiteJam approved these changes Jun 16, 2021
View reviewed changes
Copy link

@BenWhiteJam BenWhiteJam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine from BD side.

  • contact
  • testnet
  • code repo
  • support
  • community

@bkchr
Copy link
Member

bkchr commented Jun 16, 2021

@thanhtung6824 can you please merge master

@bkchr bkchr added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit B0-silent Changes should not be mentioned in any release notes labels Jun 16, 2021
@thanhtung6824
Copy link
Contributor Author

@BenWhiteJam Thank you for reviewing ;)
@bkchr I've merged from master.

@bkchr
Copy link
Member

bkchr commented Jun 23, 2021

Ty

@bkchr bkchr merged commit e4d879c into paritytech:master Jun 23, 2021
athei pushed a commit that referenced this pull request Jun 25, 2021
@thanhtung6824 @athei
Add PolkaFoundry, PolkaSmith SS58 address (#8623)
094d0c1 
* Add PolkaFoundry, PolkaSmith SS58 address

* chang decimals to 18

* fix format

* fix format
@github-actions github-actions bot mentioned this pull request Jul 8, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkchr bkchr bkchr approved these changes

@BenWhiteJam BenWhiteJam BenWhiteJam approved these changes

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thanhtung6824 @BenWhiteJam @bkchr