This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Fix #8306 #8330
Merged
Fix #8306 #8330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaka
added
A0-please_review
|
This PR is really about adding an |
romanb
approved these changes
Mar 11, 2021
bkchr
approved these changes
Mar 11, 2021
|
bot merge |
|
Checks failed; merge aborted. |
|
bot merge force |
|
Trying merge. |
|
Merge failed: |
|
bot merge force |
|
Trying merge. |
|
Merge failed: |
|
bot merge force |
|
Trying merge. |
ghost
merged commit
KalitaAlexey
pushed a commit
to KalitaAlexey/substrate
that referenced
this pull request
Jul 9, 2021
jordy25519
pushed a commit
to cennznet/substrate
that referenced
this pull request
Sep 17, 2021
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8306
If the behaviour sends
OpenthenClose, the peer state is switched toDisabled. If it then receives anOpenDesiredByRemote, the behaviour switches the peer state toIncomingto reflect the fact that the peerset is processing an incoming connection.If, then, the behaviour receives
OpenResultErrandCloseResult, as is expected if you sendOpenthenClose, then it is normal to find anIncomingthere.Before this PR, we would consider finding
Incomingthere as a bug in the code.