Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Add on_idle hook #8209

Merged
merged 48 commits into from
Mar 11, 2021
Merged

Add on_idle hook #8209

merged 48 commits into from
Mar 11, 2021

Conversation

JesseAbram
Copy link
Contributor

@JesseAbram JesseAbram commented Feb 26, 2021 •
edited by apopiak
Loading

This PR implements the on_idle hook as discussed in issue #4064

@github-actions github-actions bot added the A3-in_progress Pull request is in progress. No review needed at this stage. label Feb 26, 2021
@apopiak apopiak mentioned this pull request Feb 26, 2021
Closed
gui1117
gui1117 reviewed Feb 26, 2021
View reviewed changes
frame/support/src/dispatch.rs Outdated Show resolved Hide resolved
frame/support/src/traits.rs Outdated Show resolved Hide resolved
frame/executive/src/lib.rs Outdated Show resolved Hide resolved
@athei athei linked an issue Feb 26, 2021 that may be closed by this pull request
on_idle hook #4064
Closed
athei
athei reviewed Mar 1, 2021
View reviewed changes
frame/executive/src/lib.rs Outdated Show resolved Hide resolved
frame/support/src/traits.rs Outdated Show resolved Hide resolved
gui1117
gui1117 reviewed Mar 1, 2021
View reviewed changes
frame/support/src/dispatch.rs Outdated Show resolved Hide resolved
frame/support/src/dispatch.rs Outdated Show resolved Hide resolved
frame/support/src/dispatch.rs Outdated Show resolved Hide resolved
frame/support/src/dispatch.rs Outdated Show resolved Hide resolved
frame/support/src/dispatch.rs Outdated Show resolved Hide resolved
frame/support/src/dispatch.rs Outdated Show resolved Hide resolved
frame/support/src/dispatch.rs Outdated Show resolved Hide resolved
@gui1117
Copy link
Contributor

gui1117 commented Mar 1, 2021 •
edited
Loading

should we allow decl_module to implement on_idle? I think we can just make decl_module always define the default on_idle and not allow user to use its own implementation.

EDIT: but now that it is implemented, we can keep it.

gui1117
gui1117 reviewed Mar 1, 2021
View reviewed changes
frame/executive/src/lib.rs Outdated Show resolved Hide resolved
gui1117
gui1117 reviewed Mar 1, 2021
View reviewed changes
frame/support/src/traits.rs Outdated Show resolved Hide resolved
@athei athei changed the title add in idle hook Add on_idle hook Mar 1, 2021
JesseAbram and others added 7 commits March 1, 2021 12:03
@JesseAbram
added adjusted weight into tuple
99a8bce
@JesseAbram @gui1117
Update frame/support/src/dispatch.rs
848f147 
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
@JesseAbram @gui1117
Update frame/support/src/dispatch.rs
cf010e4 
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
@JesseAbram @gui1117
Update frame/support/src/dispatch.rs
ff4826e 
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
@JesseAbram @gui1117
Update frame/support/src/dispatch.rs
1a41fd1 
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
@JesseAbram @gui1117
Update frame/support/src/dispatch.rs
4879b79 
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
@JesseAbram @gui1117
Update frame/support/src/dispatch.rs
84820f7 
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
athei
athei reviewed Mar 1, 2021
View reviewed changes
frame/support/src/traits.rs Outdated Show resolved Hide resolved
JesseAbram and others added 2 commits March 1, 2021 12:13
@JesseAbram @gui1117
Update frame/support/src/dispatch.rs
4933986 
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
@JesseAbram
compile errors for on_idle in dispatch
45fb696
gui1117
gui1117 reviewed Mar 1, 2021
View reviewed changes
frame/support/src/dispatch.rs Outdated Show resolved Hide resolved
frame/support/src/dispatch.rs Outdated Show resolved Hide resolved
@JesseAbram @gui1117
Update frame/support/src/dispatch.rs
c62f496 
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
apopiak
apopiak reviewed Mar 9, 2021
View reviewed changes
frame/support/src/traits.rs Outdated Show resolved Hide resolved
apopiak
apopiak reviewed Mar 9, 2021
View reviewed changes
frame/support/src/traits.rs Outdated Show resolved Hide resolved
apopiak
apopiak reviewed Mar 9, 2021
View reviewed changes
frame/support/src/traits.rs Outdated Show resolved Hide resolved
apopiak
apopiak reviewed Mar 9, 2021
View reviewed changes
frame/support/src/traits.rs Outdated Show resolved Hide resolved
@JesseAbram @apopiak
Update frame/support/src/traits.rs
84c7180 
Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>
@JesseAbram JesseAbram mentioned this pull request Mar 9, 2021
Closed
apopiak
apopiak approved these changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@apopiak apopiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor docs nitpicks

frame/support/src/traits.rs Outdated Show resolved Hide resolved
frame/support/src/traits.rs Outdated Show resolved Hide resolved
frame/support/src/traits.rs Outdated Show resolved Hide resolved
JesseAbram and others added 3 commits March 11, 2021 17:01
@JesseAbram @apopiak
Update frame/support/src/traits.rs
02a42e3 
Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>
@JesseAbram @apopiak
Update frame/support/src/traits.rs
b4061e4 
Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>
@JesseAbram @apopiak
Update frame/support/src/traits.rs
855413b 
Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>
@JesseAbram JesseAbram merged commit 6b50787 into master Mar 11, 2021
@JesseAbram JesseAbram deleted the jesse-on-idle branch March 11, 2021 17:04
@shawntabrizi shawntabrizi mentioned this pull request Mar 31, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gavofyork gavofyork gavofyork left review comments

@shawntabrizi shawntabrizi shawntabrizi left review comments

@athei athei athei left review comments

@apopiak apopiak apopiak approved these changes

@gui1117 gui1117 gui1117 approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

on_idle hook
7 participants
@JesseAbram @gui1117 @athei @apopiak @gavofyork @shawntabrizi @paritytech-ci