Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

CheckSpecVersion reference fix #8056

Merged
2 commits merged into from
Feb 5, 2021
Merged

CheckSpecVersion reference fix #8056

2 commits merged into from
Feb 5, 2021

Conversation

al3mart
Copy link
Contributor

@al3mart al3mart commented Feb 5, 2021

Minor fix solving and outdated reference to CheckRuntime signed extension in pallet example. Updated to CheckSpecVersion + link to system documentation.

Closes #8000

@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Feb 5, 2021
@al3mart al3mart mentioned this pull request Feb 5, 2021
Closed
kianenigma
kianenigma reviewed Feb 5, 2021
View reviewed changes
frame/example/src/lib.rs Outdated Show resolved Hide resolved
@kianenigma kianenigma added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. and removed A0-please_review Pull request needs code review. D2-breaksapi labels Feb 5, 2021
@gui1117 @kianenigma
Update frame/example/src/lib.rs
6732a6b 
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
gui1117
gui1117 approved these changes Feb 5, 2021
View reviewed changes
Copy link
Contributor

@gui1117 gui1117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bot merge

@gui1117
Copy link
Contributor

gui1117 commented Feb 5, 2021

bot merge

@ghost
Copy link

ghost commented Feb 5, 2021

Waiting for commit status.

@ghost ghost merged commit 09ba69f into master Feb 5, 2021
@ghost ghost deleted the documentation/pallet-example-check-runtime branch February 5, 2021 13:51
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kianenigma kianenigma kianenigma approved these changes

@gui1117 gui1117 gui1117 approved these changes

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Outdated reference in Example pallet to Frame System
4 participants
@al3mart @gui1117 @kianenigma @paritytech-ci