This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Frame System Benchmarking #5834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apopiak
reviewed
Apr 30, 2020
Comment on lines
+52
to
+54
| // `set_code` was not benchmarked because it is pretty hard to come up with a real | ||
| // Wasm runtime to test the upgrade with. But this is okay because we will make | ||
| // `set_code` take a full block anyway. |
There was a problem hiding this comment.
Would be good to benchmark (more, like, smoketest) whether you can find a WASM that would take longer than the block time to call set_code on. Not sure how to do that, though.
There was a problem hiding this comment.
Would have to be something we test more manually or with some other setup versus using our runtime benchmarking
There was a problem hiding this comment.
maybe open an issue, would be good to follow up
There was a problem hiding this comment.
Basically, they all have an effective weight higher than a block. Just something we have to live with. It's a root call so still basically fine.
gavofyork
approved these changes
Apr 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a crate that benchmarks the various extrinsics in
frame_system.