This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Replace Condvars with blocking channel #5815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkpar
approved these changes
Apr 28, 2020
bkchr
reviewed
Apr 28, 2020
| let pair = Arc::new((Mutex::new(false), Condvar::new())); | ||
| let pair_clone = pair.clone(); | ||
|
|
||
| let (sender, receiver) = std::sync::mpsc::channel(); |
There was a problem hiding this comment.
I still don't understand why all this code isn't just:
futures::executor::block_on(futures::future::join_all(pending))
There was a problem hiding this comment.
Integration tests (test_sync) are panicking, they use it and you can't have one executor inside another.
bkchr
suggested changes
Apr 28, 2020
bkchr
approved these changes
Apr 28, 2020
|
Fails to compile |
gavofyork
added
A8-mergeoncegreen
and removed
A0-please_review
bkchr
reviewed
Apr 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should've been done it initially.