This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Send a status message on block announce handshake #5726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaka
added
A0-please_review
6 tasks
twittner
approved these changes
Apr 21, 2020
tomaka
added
A8-mergeoncegreen
and removed
A0-please_review
|
I'm not sure how to make the CI green. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #5670
This PR is the same as #5665, except that it sends a proper handshake for the block announces substream, which will become the "main sync substream".
For this PR, I had to add a
UpdateHandshakemessage that we send to all the node handlers.