This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Add new RPC method to get the chain type #5576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new RPC method to get the chain type of the running chain. The chain type needs to be specified in the chain spec. This should make it easier for tools/UI to display extra information without needing to rely on parsing the chain name.
tomusdrw
suggested changes
Apr 8, 2020
| fn system_type_works() { | ||
| assert_eq!( | ||
| api(None).system_type().unwrap(), | ||
| Default::default(), |
There was a problem hiding this comment.
Would prefer something more explicit, but can live with that :)
client/rpc-api/Cargo.toml
Outdated
| @@ -21,6 +21,7 @@ parking_lot = "0.10.0" | |||
| sp-core = { version = "2.0.0-alpha.5", path = "../../primitives/core" } | |||
| sp-version = { version = "2.0.0-alpha.5", path = "../../primitives/version" } | |||
| sp-runtime = { path = "../../primitives/runtime" , version = "2.0.0-alpha.5"} | |||
| sc-chain-spec = { path = "../chain-spec" , version = "2.0.0-alpha.5"} | |||
There was a problem hiding this comment.
rpc-api should not depend on client stuff. The whole point of this crate is to avoid brining in 90% of substrate when just needing the APIs. Can we move the type to some primitives?
Co-Authored-By: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
tomusdrw
approved these changes
Apr 8, 2020
client/rpc/Cargo.toml
Outdated
| @@ -30,6 +30,7 @@ sp-state-machine = { version = "0.8.0-alpha.5", path = "../../primitives/state-m | |||
| sc-executor = { version = "0.8.0-alpha.5", path = "../executor" } | |||
| sc-block-builder = { version = "0.8.0-alpha.5", path = "../../client/block-builder" } | |||
| sc-keystore = { version = "2.0.0-alpha.5", path = "../keystore" } | |||
| sc-chain-spec = { version = "2.0.0-alpha.5", path = "../chain-spec" } | |||
There was a problem hiding this comment.
Could be sp-chain-spec now it seems.
client/rpc-api/src/system/mod.rs
Outdated
| pub use self::gen_client::Client as SystemClient; | ||
| use sp_chain_spec::Properties; |
There was a problem hiding this comment.
Might be worth to either consistently import both Properties and ChainType or use full path in both places.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new RPC method to get the chain type of the running chain.
The chain type needs to be specified in the chain spec. This should make
it easier for tools/UI to display extra information without needing to
rely on parsing the chain name.
Let's keep @jacogr sane :)