This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Introduce default-setting prime for collective #5137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
added
A0-please_review
shawntabrizi
reviewed
Mar 5, 2020
Comment on lines
+192
to
+194
| let old = Members::<T, I>::get(); | ||
| <Self as ChangeMembers<T::AccountId>>::set_members_sorted(&new_members[..], &old); | ||
| Prime::<T, I>::set(prime); |
There was a problem hiding this comment.
Updating Members storage with new_members has been lost with this change.
There was a problem hiding this comment.
yeah. that was superfluous logic as it happens anyway in <Self as ChangeMembers<T::AccountId>>::set_members_sorted(&new_members[..], &old).
There was a problem hiding this comment.
I think this is an issue since other parts of logic rely on Self::members() which reads from the local members list.
We need some trait to tell the module where to read the correct list of members from, and use it here.
There was a problem hiding this comment.
Not sure what you mean. Members is always kept up to date regardless of how the set is changed.
shawntabrizi
reviewed
Mar 5, 2020
Co-Authored-By: Shawn Tabrizi <shawntabrizi@gmail.com>
shawntabrizi
approved these changes
Mar 5, 2020
General-Beck
pushed a commit
to General-Beck/substrate
that referenced
this pull request
Mar 6, 2020
* Introduce default-setting prime for collective * Docs. * Elections phragmen supports prime * Fix * Membership supports prime * Fix * Update frame/collective/src/lib.rs Co-Authored-By: Shawn Tabrizi <shawntabrizi@gmail.com> Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
General-Beck
pushed a commit
to General-Beck/substrate
that referenced
this pull request
Mar 17, 2020
* Introduce default-setting prime for collective * Docs. * Elections phragmen supports prime * Fix * Membership supports prime * Fix * Update frame/collective/src/lib.rs Co-Authored-By: Shawn Tabrizi <shawntabrizi@gmail.com> Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the existence of a "prime member" of the collective whose vote acts as the default for any other members.
CC @jacogr