This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Introduce OnReapAccount
#4585
Merged
Introduce OnReapAccount
#4585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawntabrizi
requested review from
kianenigma,
pepyakin and
gui1117
as code owners
shawntabrizi
added
the
A3-in_progress
|
Companion PR for Polkadot: paritytech/polkadot#748 |
shawntabrizi
added
A8-looksgood
and removed
A3-in_progress
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing a FRAME pallet, I found myself wanting access to an
OnReapAccounttrait which signals to my module when an account is fully reaped from the system.I could imagine that such a trait could be regularly used by other pallets (maybe even our own) to ensure that when an account is reaped, all possible storage items for that account are cleaned up.
The only main change here besides the introduction of this new trait is actually using it for cleaning up the
AccountNoncein the system module. Before, we were removingAccountNoncewithin the balances pallet, but now we will actually clean it up properly using this trait. This may beniefit other pallet creators who want to create alternatives to our balances module.Open to feedback about why this is a good or bad idea.