This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Refactor Client consumers to use only chain info where needed #4516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikVolf
requested review from
andresilva,
Demi-Marie and
tomusdrw
as code owners
|
It looks like @NikVolf signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
arkpar
approved these changes
Jan 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now Client api consumers request full
ClientInfowhen they only needsp_blockchain::Info, this addresses this.While now it is rather cheap to construct ClientInfo (though it requires shared cache locking and cache structure traversing already), this is expected to be not that cheap (more memory stats, along with I/o stats)