This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Hard-cap the execution time of custom contract calls. #4226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HCastano
reviewed
Nov 27, 2019
| /// prevent blocking the RPC for too long. | ||
| /// | ||
| /// Based on W3F research spreadsheet: | ||
| /// https://docs.google.com/spreadsheets/d/1h0RqncdqiWI4KgxO0z9JIpZEJESXjX_ZCK6LFX6veDo/view |
There was a problem hiding this comment.
I don't have permissions to view this, so I'm guessing others won't either. Who do we talk to about making this public?
HCastano
reviewed
Nov 27, 2019
| @@ -148,6 +157,19 @@ where | |||
| data: None, | |||
| })?; | |||
|
|
|||
| let max_gas_limit = 5 * GAS_PER_SECOND; | |||
There was a problem hiding this comment.
I'd add the "interpretation" you put in the PR description as a comment here
|
Some nits, but looks good |
HCastano
approved these changes
Nov 27, 2019
pepyakin
approved these changes
Nov 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent RPC spam, make sure we disallow contract queries that may take forever to complete. The limit is now based on the assumption that:
Current default block weight limit is
1e9as well, so this limit can be interpreted as either:I'd rather be conservative here - if this ever creates issues we can revisit later.