This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Switch to new kvdb-rocksdb #4186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rocksdb and `wasmtime-environ` both link `zstd`. In the final link step, this leads to linking errors because of duplicate symbols. The linked Rocksdb fixes this by using `zstd-sys` as well. However, this currently also requires modifications in `zstd-sys`. Someone will need to come up with a better implementation.
|
@bkchr a few failing tests here it seems... cargo benches, in particular fails on linkage. |
gavofyork
added
A7-looksgoodtestsfail
and removed
A0-please_review
bkchr
changed the title
marcio-diaz
approved these changes
Nov 23, 2019
Co-Authored-By: Shawn Tabrizi <shawntabrizi@gmail.com>
shawntabrizi
approved these changes
Nov 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr switches to the new kvdb-rocksdb, that will be released in the next days. However, we already need it now to fix the linking errors in Polkadot.