-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Rename Palette to FRAME #4182
Rename Palette to FRAME #4182
Conversation
Please tell me this is the final rename... |
Me too. |
I think the idea is to keep renaming it until everyone is of the opinion that sticking with a name they don't like is better than having to change it again. |
d219489
to
51ee631
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor changes requested.
docs/README.adoc
Outdated
@@ -446,8 +446,8 @@ substrate-trie | |||
sr-api, sr-io, sr-primitives, sr-sandbox, sr-std, sr-version | |||
* Substrate Runtime Module Library (SRML) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also needs renaming, I guess?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are actually a number of docs which still need to be fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I patched this, but we should do a docs pass at another time (so we dont block polkadot release)
@@ -131,7 +131,7 @@ pub mod ed25519 { | |||
|
|||
/// The local storage database key under which the worker progress status | |||
/// is tracked. | |||
const DB_KEY: &[u8] = b"palette/im-online-worker-status"; | |||
const DB_KEY: &[u8] = b"frame/im-online-worker-status"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this might be a problem on a soft-upgrade ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably remove this from the key all together right?
Co-Authored-By: Benjamin Kampmann <ben.kampmann@googlemail.com>
Co-Authored-By: Benjamin Kampmann <ben.kampmann@googlemail.com>
Can we stick to "srml"? Short and understandable |
@shawntabrizi @gavofyork me three. |
@shawntabrizi @gavofyork me four. |
@kigawas @nodebreaker-carlsagan @hskang9 @gavofyork We would generally appreciate if you didn't name things after Substrate (or Rust). Therefore all Polkadot implementations (with different languages, frameworks, etc.) are somewhat on equal ground. Please avoid "srml". |
if you regard "srml" as something like "gnu" or "unix" then it's just a name with 4 characters. |
Acronyms are fine if they describe some generic components (Unix > Multics: "Multiplexed Information and Computing System"). But "srml" explicitly names Substrate, which is a Rust Framework. |
@lamafab I am not offering opinions but wanting to point out the code in this repository is Substrate, a Rust framework. If someone reimplement it with another language, it will just be another different framework with a different name. I don't see why the name of this framework matters to other PRE (Polkadot Runtime Environment) framework. |
This issue has been resolved and the PR merged. If you want to have a conversation about preferred names, this isn't the place for it. Locked the conversation to prevent further spamming the participants. |
To further avoid confusion between "Palette" and "Pallet", the libraries formerly known as the SRML will be called FRAME.
FRAME: Framework for Runtime Aggregation of Modularised Entities