Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Rename Palette to FRAME #4182

Merged

Conversation

shawntabrizi
Copy link
Member

@shawntabrizi shawntabrizi commented Nov 22, 2019

To further avoid confusion between "Palette" and "Pallet", the libraries formerly known as the SRML will be called FRAME.

FRAME: Framework for Runtime Aggregation of Modularised Entities

FRAME is our framework for developing new Substrate pallets. Pallets are a special kind of Rust module from which Substrate runtimes can be composed. Each pallet has its own discrete logic which can modify the features and functionality of your blockchain's state transition function.

@xlc
Copy link
Contributor

xlc commented Nov 22, 2019

Please tell me this is the final rename...

@gavofyork
Copy link
Member

Me too.

@gavofyork
Copy link
Member

gavofyork commented Nov 22, 2019

I think the idea is to keep renaming it until everyone is of the opinion that sticking with a name they don't like is better than having to change it again.

@shawntabrizi shawntabrizi reopened this Nov 22, 2019
Copy link
Contributor

@gnunicorn gnunicorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes requested.

docs/README.adoc Outdated Show resolved Hide resolved
docs/README.adoc Outdated
@@ -446,8 +446,8 @@ substrate-trie
sr-api, sr-io, sr-primitives, sr-sandbox, sr-std, sr-version
* Substrate Runtime Module Library (SRML)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs renaming, I guess?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are actually a number of docs which still need to be fixed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I patched this, but we should do a docs pass at another time (so we dont block polkadot release)

docs/Structure.adoc Outdated Show resolved Hide resolved
@@ -131,7 +131,7 @@ pub mod ed25519 {

/// The local storage database key under which the worker progress status
/// is tracked.
const DB_KEY: &[u8] = b"palette/im-online-worker-status";
const DB_KEY: &[u8] = b"frame/im-online-worker-status";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might be a problem on a soft-upgrade ...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably remove this from the key all together right?

shawntabrizi and others added 3 commits November 22, 2019 18:38
Co-Authored-By: Benjamin Kampmann <ben.kampmann@googlemail.com>
Co-Authored-By: Benjamin Kampmann <ben.kampmann@googlemail.com>
@shawntabrizi shawntabrizi merged commit 1f26179 into paritytech:master Nov 22, 2019
@shawntabrizi shawntabrizi deleted the shawntabrizi-frame-rename branch November 22, 2019 18:21
@kigawas
Copy link
Contributor

kigawas commented Nov 25, 2019

I think the idea is to keep renaming it until everyone is of the opinion that sticking with a name they don't like is better than having to change it again.

Can we stick to "srml"? Short and understandable

@nodebreaker0-0
Copy link
Contributor

nodebreaker0-0 commented Nov 26, 2019

@shawntabrizi @gavofyork me three.

@hskang9
Copy link
Contributor

hskang9 commented Nov 26, 2019

@shawntabrizi @gavofyork me four.

@lamafab
Copy link

lamafab commented Nov 26, 2019

I think the idea is to keep renaming it until everyone is of the opinion that sticking with a name they don't like is better than having to change it again.

Can we stick to "srml"? Short and understandable

@kigawas @nodebreaker-carlsagan @hskang9 @gavofyork We would generally appreciate if you didn't name things after Substrate (or Rust). Therefore all Polkadot implementations (with different languages, frameworks, etc.) are somewhat on equal ground. Please avoid "srml".

@kigawas
Copy link
Contributor

kigawas commented Nov 27, 2019

I think the idea is to keep renaming it until everyone is of the opinion that sticking with a name they don't like is better than having to change it again.

Can we stick to "srml"? Short and understandable

@kigawas @nodebreaker-carlsagan @hskang9 @gavofyork We would generally appreciate if you didn't name things after Substrate (or Rust). Therefore all Polkadot implementations (with different languages, frameworks, etc.) are somewhat on equal ground. Please avoid "srml".

if you regard "srml" as something like "gnu" or "unix" then it's just a name with 4 characters.

@kigawas
Copy link
Contributor

kigawas commented Nov 27, 2019

And "frame" or "pallet" is too generic - sounds like a chemistry factory

image
image
image

@lamafab
Copy link

lamafab commented Nov 27, 2019

@kigawas

if you regard "srml" as something like "gnu" or "unix" then it's just a name with 4 characters.

Acronyms are fine if they describe some generic components (Unix > Multics: "Multiplexed Information and Computing System"). But "srml" explicitly names Substrate, which is a Rust Framework.

@xlc
Copy link
Contributor

xlc commented Nov 27, 2019

@lamafab I am not offering opinions but wanting to point out the code in this repository is Substrate, a Rust framework. If someone reimplement it with another language, it will just be another different framework with a different name. I don't see why the name of this framework matters to other PRE (Polkadot Runtime Environment) framework.

@gnunicorn
Copy link
Contributor

This issue has been resolved and the PR merged. If you want to have a conversation about preferred names, this isn't the place for it. Locked the conversation to prevent further spamming the participants.

@paritytech paritytech locked as resolved and limited conversation to collaborators Nov 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants