This repository was archived by the owner on Nov 15, 2023. It is now read-only.
allow slippage to be set when pay by swap #14680
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilescope
added
A0-please_review
gilescope
commented
Jul 29, 2023
frame/transaction-payment/asset-conversion-tx-payment/src/payment.rs
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
Noneis passed as the minimum swap return amounts when paying by swap. In a heavy MEV environment this could lead to people paying too much in fees. This PR surfaces the optionalmax_feeparameter so that wallets can (and ideally should) set this to a sensible value to ensure that there is a limit to how much a MEV bot could manipulate the fx rates and the transaction still succeed.