This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
chain-spec-builder
: redundant file removed src/main.rs
#14600
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalkucharczyk
added
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit
labels
Jul 20, 2023
michalkucharczyk
changed the title
chain-spec-builder: redundant functions removed from main
Jul 20, 2023
chain-spec-builder
: redundant functions removed from main.rs
michalkucharczyk
changed the title
Jul 20, 2023
chain-spec-builder
: redundant functions removed from main.rs
chain-spec-builder
: duplicated functions removed from main.rs
ggwpez
approved these changes
Jul 20, 2023
altonen
approved these changes
Jul 20, 2023
My bad. We don't need this file at all.... |
Just wanted to say this. I already thought that I was drunk yesterday while doing this. 😂 But yeah didn't see this file before.. |
bkchr
approved these changes
Jul 20, 2023
koute
approved these changes
Jul 20, 2023
michalkucharczyk
changed the title
Jul 20, 2023
chain-spec-builder
: duplicated functions removed from main.rs
chain-spec-builder
: redundant file removed src/main.rs
bot merge |
Waiting for commit status. |
Ank4n
pushed a commit
that referenced
this pull request
Jul 22, 2023
* chain-spec-builder: redundant functions removed from main * src/main.rs removed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up of: #14581