Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

chain-spec-builder: redundant file removed src/main.rs #14600

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

michalkucharczyk
Copy link
Contributor

@michalkucharczyk michalkucharczyk commented Jul 20, 2023

follow-up of: #14581

@michalkucharczyk michalkucharczyk added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jul 20, 2023
@michalkucharczyk michalkucharczyk changed the title chain-spec-builder: redundant functions removed from main chain-spec-builder: redundant functions removed from main.rs Jul 20, 2023
@michalkucharczyk michalkucharczyk requested review from kianenigma and a team July 20, 2023 11:21
@michalkucharczyk michalkucharczyk changed the title chain-spec-builder: redundant functions removed from main.rs chain-spec-builder: duplicated functions removed from main.rs Jul 20, 2023
@michalkucharczyk michalkucharczyk added the A0-please_review Pull request needs code review. label Jul 20, 2023
@michalkucharczyk
Copy link
Contributor Author

michalkucharczyk commented Jul 20, 2023

My bad. We don't need this file at all....

@bkchr
Copy link
Member

bkchr commented Jul 20, 2023

My bad. We don't need this file at all....

Just wanted to say this. I already thought that I was drunk yesterday while doing this. 😂 But yeah didn't see this file before..

@michalkucharczyk michalkucharczyk changed the title chain-spec-builder: duplicated functions removed from main.rs chain-spec-builder: redundant file removed src/main.rs Jul 20, 2023
@michalkucharczyk
Copy link
Contributor Author

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit 73c1388 into master Jul 20, 2023
5 checks passed
@paritytech-processbot paritytech-processbot bot deleted the mku-chain-spec-builder-cleanup branch July 20, 2023 12:22
Ank4n pushed a commit that referenced this pull request Jul 22, 2023
* chain-spec-builder: redundant functions removed from main

* src/main.rs removed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants