This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Run all tests with try-runtime feature enabled
#14396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some tests that are guarded behind the `try-runtime` feature which are currently not being executed. This pull requests changes this and enables the feature for the test run.
bkchr
added
A0-please_review
pgherveou
approved these changes
Jun 15, 2023
frame/contracts/src/migration.rs
Outdated
Comment on lines
194
to
198
| /// | ||
| /// If `RUN_ALL_STEPS == true` and `try-runtime` is enabled, this will run all the migrations inside | ||
| /// `on_runtime_upgrade`. This should be set to false in tests that want to ensure the step by step | ||
| /// migration works. | ||
| pub struct Migration<T: Config, const RUN_ALL_STEPS: bool = true>(PhantomData<T>); |
There was a problem hiding this comment.
question: do we also run the tests in CI without try_runtime? in which case I think it would be fine to just disable the tests using this struct and not add this extra RUN_ALL_STEPS
If not, maybe we change the name to TRY_ALL_STEPS or TEST_ALL_STEPS to make it clear that this is just intended for testing purpose.
There was a problem hiding this comment.
With the changes of the pr, we run all tests with try-runtime.
juangirini
approved these changes
Jun 16, 2023
altaua
approved these changes
Jun 16, 2023
alvicsam
approved these changes
Jun 16, 2023
gilescope
approved these changes
Jun 16, 2023
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
* Run all tests with `try-runtime` feature enabled There are some tests that are guarded behind the `try-runtime` feature which are currently not being executed. This pull requests changes this and enables the feature for the test run. * Add some docs * Rename variable
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some tests that are guarded behind the
try-runtimefeature which are currently not being executed. This pull requests changes this and enables the feature for the test run.