Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Make Pay trait from salaries pallet more generic #13609

Merged
merged 9 commits into from
Mar 15, 2023

Conversation

franciscoaguirre
Copy link
Contributor

@franciscoaguirre franciscoaguirre commented Mar 15, 2023

  • Moved the Pay trait to live in frame_support.
  • Added a new associated type AssetKind to enable usage of this trait via XCM (and possibly others?).
  • Changed AccountId to Beneficiary since we may want to pay more general concepts like XCM's MultiLocation
  • Used unit type for AssetKind on the salary pallet

Solves #13603.

@franciscoaguirre franciscoaguirre added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Mar 15, 2023
@franciscoaguirre franciscoaguirre marked this pull request as draft March 15, 2023 15:18
@franciscoaguirre franciscoaguirre marked this pull request as ready for review March 15, 2023 17:26
@franciscoaguirre
Copy link
Contributor Author

bot rebase

@franciscoaguirre
Copy link
Contributor Author

bot merge

@franciscoaguirre
Copy link
Contributor Author

bot rebase

@franciscoaguirre
Copy link
Contributor Author

bot clean

@command-bot command-bot bot deleted a comment from paritytech-processbot bot Mar 15, 2023
@command-bot command-bot bot deleted a comment from paritytech-processbot bot Mar 15, 2023
@command-bot command-bot bot deleted a comment from paritytech-processbot bot Mar 15, 2023
@command-bot command-bot bot deleted a comment from paritytech-processbot bot Mar 15, 2023
@franciscoaguirre
Copy link
Contributor Author

bot rebase

@paritytech-processbot
Copy link

Rebased

@franciscoaguirre
Copy link
Contributor Author

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit 86731af into master Mar 15, 2023
@paritytech-processbot paritytech-processbot bot deleted the cisco-pay-trait-generic branch March 15, 2023 21:04
breathx pushed a commit to gear-tech/substrate that referenced this pull request Apr 22, 2023
* Make Pay trait from salaries pallet more generic

* Rename and add missing

* Update frame/support/src/traits/tokens/pay.rs

* Update pay.rs

* Update pay.rs

* Update pay.rs

* Add better documentation for the AssetKind associated type

---------

Co-authored-by: Gavin Wood <gavin@parity.io>
Co-authored-by: parity-processbot <>
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
* Make Pay trait from salaries pallet more generic

* Rename and add missing

* Update frame/support/src/traits/tokens/pay.rs

* Update pay.rs

* Update pay.rs

* Update pay.rs

* Add better documentation for the AssetKind associated type

---------

Co-authored-by: Gavin Wood <gavin@parity.io>
Co-authored-by: parity-processbot <>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants