This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athei
added
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit
labels
Feb 1, 2022
athei
requested review from
acatangiu,
andresilva,
kianenigma and
sorpaas
as code owners
February 1, 2022 14:25
ascjones
approved these changes
Feb 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Relevant issue in |
dvdplm
approved these changes
Feb 1, 2022
I don't get why the polkadot CI job fails. Polkadot uses those dependencies without any version. |
This reverts commit f86c6db.
Merged
agryaznov
pushed a commit
to agryaznov/substrate
that referenced
this pull request
Feb 4, 2022
* Bump sp-storage * Bump sp-rpc * Bump sp-io * Bump sp-trie * Bump sp-state-machine * Bump sp-externalities * Bump sp-keystore * Bump sp-application-crypto * Bump pallet-contracts-primitives * Bump sp-core * Bump sp-runtime-interface * Bump sp-wasm-interface * Bump sp-runtime * Bump sp-storage * Update lock file * Revert "Bump sp-storage" This reverts commit f86c6db. * Update lock file
Wizdave97
pushed a commit
to ComposableFi/substrate
that referenced
this pull request
Feb 4, 2022
* Bump sp-storage * Bump sp-rpc * Bump sp-io * Bump sp-trie * Bump sp-state-machine * Bump sp-externalities * Bump sp-keystore * Bump sp-application-crypto * Bump pallet-contracts-primitives * Bump sp-core * Bump sp-runtime-interface * Bump sp-wasm-interface * Bump sp-runtime * Bump sp-storage * Update lock file * Revert "Bump sp-storage" This reverts commit f86c6db. * Update lock file
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
* Bump sp-storage * Bump sp-rpc * Bump sp-io * Bump sp-trie * Bump sp-state-machine * Bump sp-externalities * Bump sp-keystore * Bump sp-application-crypto * Bump pallet-contracts-primitives * Bump sp-core * Bump sp-runtime-interface * Bump sp-wasm-interface * Bump sp-runtime * Bump sp-storage * Update lock file * Revert "Bump sp-storage" This reverts commit f86c6db. * Update lock file
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* Bump sp-storage * Bump sp-rpc * Bump sp-io * Bump sp-trie * Bump sp-state-machine * Bump sp-externalities * Bump sp-keystore * Bump sp-application-crypto * Bump pallet-contracts-primitives * Bump sp-core * Bump sp-runtime-interface * Bump sp-wasm-interface * Bump sp-runtime * Bump sp-storage * Update lock file * Revert "Bump sp-storage" This reverts commit f86c6db. * Update lock file
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This crate is needed in order to release
cargo contract
to crates.io. I usedcargo unleash
to determine which crates need a bump. I will also usecargo unleash
to release those crates once this PR is merged. I usedcargo edit
to help with bumping version numbers. I thinkcargo unleash
can't do it. I also opted to bump the major version of any crate that yielded build errors as I can't determine the nature of each change.Please note that I am not releasing the whole dependency graph of
pallet-contracts-primitives
but merely the crates which introduced compile breakage when not bumped.This is what I did and also the list of packages which will be released as soon as this is merged: