Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

BEEFY subscription fires multiple times for the same commitment #10684

Closed
wants to merge 26 commits into from
Closed

BEEFY subscription fires multiple times for the same commitment #10684

Changes from 2 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
04e9166
prevent duplicate justification notifications
Wizdave97 Jan 17, 2022
acbc825
Merge branch 'master' of https://github.com/paritytech/substrate into…
Wizdave97 Jan 17, 2022
8cc6ac7
minor fix
Wizdave97 Jan 17, 2022
e98492b
clean up
Wizdave97 Jan 17, 2022
2ca50e3
fix failing tests
Wizdave97 Jan 17, 2022
1029b26
minor fix
Wizdave97 Jan 17, 2022
0d40e9a
add comments to test
Wizdave97 Jan 17, 2022
5cbf9d2
fix typo
Wizdave97 Jan 17, 2022
b20926c
minor fix
Wizdave97 Jan 18, 2022
307a147
Merge branch 'master' of https://github.com/paritytech/substrate into…
Wizdave97 Jan 19, 2022
9147724
Merge branch 'master' of https://github.com/paritytech/substrate into…
Wizdave97 Jan 21, 2022
5253c95
Merge branch 'master' of https://github.com/paritytech/substrate into…
Wizdave97 Jan 24, 2022
c6a8a2f
Merge branch 'paritytech:master' into david/beefy-subscribe-justifica…
Wizdave97 Jan 24, 2022
fe0f7ec
updated test case
Wizdave97 Jan 24, 2022
2be30bb
remove unreliable tests
Wizdave97 Jan 24, 2022
61088bd
Merge branch 'paritytech:master' into david/beefy-subscribe-justifica…
Wizdave97 Jan 24, 2022
c302c39
minor fix
Wizdave97 Jan 25, 2022
b213cce
Merge branch 'david/beefy-subscribe-justification-rpc' of github.com:…
Wizdave97 Jan 25, 2022
d0846ed
fix
Wizdave97 Jan 25, 2022
925ce6b
Merge branch 'paritytech:master' into david/beefy-subscribe-justifica…
Wizdave97 Jan 26, 2022
74e2b6c
Merge branch 'master' of https://github.com/paritytech/substrate into…
Wizdave97 Jan 27, 2022
99adcdf
add justification dedup test case
Wizdave97 Jan 27, 2022
11aba7c
Merge branch 'david/beefy-subscribe-justification-rpc' of github.com:…
Wizdave97 Jan 27, 2022
c3b7f22
fix tests
Wizdave97 Jan 28, 2022
d02bb2f
Merge branch 'master' of https://github.com/paritytech/substrate into…
Wizdave97 Jan 28, 2022
854cd0a
fix test assertion string
Wizdave97 Jan 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/beefy/rpc/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,7 @@ mod tests {
);
}

fn create_commitment(block_number: u32) -> BeefySignedCommitment<Block> {
fn create_commitment(block_number: u64) -> BeefySignedCommitment<Block> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

block numbers are actually u32

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The susbtrate-test-runtime uses a u64

let payload = Payload::new(known_payload_ids::MMR_ROOT_ID, "Hello World!".encode());
BeefySignedCommitment::<Block> {
commitment: beefy_primitives::Commitment { payload, block_number, validator_set_id: 0 },
Expand Down