Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Introduce temporary GitLab & GHA benchmarking jobs #10311

Merged
merged 8 commits into from
Nov 24, 2021

Conversation

rcny
Copy link
Contributor

@rcny rcny commented Nov 18, 2021

This PR makes the following changes to the project's pipeline as a part of https://github.com/paritytech/ci_cd/issues/256:

  • add bench-test-full-crypto-feature job as a clone of test-full-crypto-feature. test-full-crypto-feature was chosen for this benchmarking test because it runs fast and jobs won't be queuing on the special single concurrency bench runner
  • disable sccache for this job with unsetting RUSTC_WRAPPER environment variable
  • calculate job's total script execution time and push the result to the metrics storage

GitHub Actions workflow was added with the same feature set as its GitLab counterpart.

@rcny rcny added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Nov 18, 2021
@rcny rcny self-assigned this Nov 18, 2021
@rcny rcny requested a review from a team as a code owner November 18, 2021 19:21
@rcny
Copy link
Contributor Author

rcny commented Nov 18, 2021

Temporarily blocked by the lack of network access, fix is here.

@rcny rcny marked this pull request as draft November 18, 2021 21:17
@rcny
Copy link
Contributor Author

rcny commented Nov 22, 2021

Temporarily blocked by the lack of network access, fix is here.

Waiting for the fix to be applied.

@rcny
Copy link
Contributor Author

rcny commented Nov 22, 2021

Networking issue is fixed.

@rcny rcny marked this pull request as ready for review November 22, 2021 17:54
@rcny rcny changed the title Introduce temporary GitLab benchmarking job Introduce temporary GitLab & GHA benchmarking jobs Nov 22, 2021
@TriplEight
Copy link
Contributor

TriplEight commented Nov 23, 2021

had to tab the comments inside of the run: blocks to make them somewhat readable - my editor doesn't highlight them, too.

@dvdplm
Copy link
Contributor

dvdplm commented Nov 23, 2021

Looks sane to me, but @bkchr and @andresilva should take a look too.

@TriplEight TriplEight merged commit 3f657a5 into master Nov 24, 2021
@TriplEight TriplEight deleted the vi-gl-comparison-job branch November 24, 2021 11:10
@TriplEight
Copy link
Contributor

grishasobol pushed a commit to gear-tech/substrate that referenced this pull request Mar 28, 2022
* Introduce temporary bench job

* Add runner label

* CI: bench GHA

* CI: bench GHA

* CI: docs

* CI: more docs

* CI: run on master only

Co-authored-by: Denis P <denis.pisarev@parity.io>
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
* Introduce temporary bench job

* Add runner label

* CI: bench GHA

* CI: bench GHA

* CI: docs

* CI: more docs

* CI: run on master only

Co-authored-by: Denis P <denis.pisarev@parity.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants