schnorrkel/serde

[burdges]

We use schnorrkel's serde dependency at https://github.com/paritytech/substrate/blob/master/primitives/core/Cargo.toml#L104 which makes me nervous since not sure how stable serde is. We might explore removing it somehow and using the stable from_bytes and to_bytes instead.

I'm worried about shit like some serde dependency changing a UTF or Unicode ligature or something, but maybe stuff like bincode is fine.

ref schnorrkel's serde revision history https://github.com/w3f/schnorrkel/commits/master/src/serdey.rs

[burdges]

Is this maybe only being used for tests? Appears serde_json is only a dev dependency. If so, fine then maybe we can feature gate the dependency somehow?