This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Improve test suite for runtime modules. should be tested with non null ExistentialDeposit #3798
Closed
Description
I found an issue in treasury due to the test suite having ExistentialDeposit to 0 #3797
if you grep to other modules there is:
./srml/utility/src/lib.rs:111: pub const ExistentialDeposit: u64 = 0;
./srml/democracy/src/lib.rs:1027: pub const ExistentialDeposit: u64 = 0;
./srml/elections/src/mock.rs:59: pub const ExistentialDeposit: u64 = 0;
./srml/scored-pool/src/mock.rs:52: pub const ExistentialDeposit: u64 = 0;
./srml/example/src/lib.rs:679: pub const ExistentialDeposit: u64 = 0;
./srml/executive/src/lib.rs:357: pub const ExistentialDeposit: u64 = 0;
./srml/council/src/lib.rs:127: pub const ExistentialDeposit: u64 = 0;
I think test suite should take into account existential deposit in general this is more relevant and probably catch more bug.
Actually I think all parameter types in
parameter_types! {
pub const ExistentialDeposit: u64 = 0;
pub const TransferFee: u64 = 0;
pub const CreationFee: u64 = 0;
pub const TransactionBaseFee: u64 = 0;
pub const TransactionByteFee: u64 = 0;
}
should be set to a value different from 0 in general (except in some precise test obviously)
Activity