tests for proxy and utility for tx-pause

fmt
paritytech · Oct 11, 2022 · ad27654 · ad27654
1 parent adb3ab8
commit ad27654
Show file tree

Hide file tree

Showing 4 changed files with 59 additions and 14 deletions.
diff --git a/bin/node/runtime/src/lib.rs b/bin/node/runtime/src/lib.rs
@@ -219,12 +219,10 @@ pub struct UnfilterableCallNames;
 /// Make Balances::transfer_keep_alive unfilterable, accept all others.
 impl Contains<FullNameOf<Runtime>> for UnfilterableCallNames {
 	fn contains(full_name: &FullNameOf<Runtime>) -> bool {
-		let unpausables: Vec<FullNameOf<Runtime>> = vec![
-			(
-				b"Balances".to_vec().try_into().unwrap(),
-				Some(b"transfer_keep_alive".to_vec().try_into().unwrap()),
-			),
-		];
+		let unpausables: Vec<FullNameOf<Runtime>> = vec![(
+			b"Balances".to_vec().try_into().unwrap(),
+			Some(b"transfer_keep_alive".to_vec().try_into().unwrap()),
+		)];
 
 		for unpausable_call in unpausables {
 			let (pallet_name, maybe_call_name) = full_name;

diff --git a/frame/safe-mode/src/mock.rs b/frame/safe-mode/src/mock.rs
@@ -141,7 +141,7 @@ pub struct UnfilterableCalls;
 impl Contains<RuntimeCall> for UnfilterableCalls {
 	fn contains(call: &RuntimeCall) -> bool {
 		match call {
-			RuntimeCall::Balances(_)  => false,
+			RuntimeCall::Balances(_) => false,
 			_ => true,
 		}
 	}

diff --git a/frame/safe-mode/src/tests.rs b/frame/safe-mode/src/tests.rs
@@ -134,16 +134,16 @@ fn can_filter_balance_calls_when_activated() {
 	});
 }
 
-
 #[test]
 fn can_filter_balance_in_batch_when_activated() {
 	new_test_ext().execute_with(|| {
-		let batch_call = RuntimeCall::Utility(pallet_utility::Call::batch { calls: vec![call_transfer()]});
+		let batch_call =
+			RuntimeCall::Utility(pallet_utility::Call::batch { calls: vec![call_transfer()] });
 
 		assert_ok!(batch_call.clone().dispatch(Origin::signed(0)));
 
 		assert_ok!(SafeMode::activate(Origin::signed(0)));
-		
+
 		assert_ok!(batch_call.clone().dispatch(Origin::signed(0)));
 		System::assert_last_event(
 			pallet_utility::Event::BatchInterrupted {
@@ -161,13 +161,16 @@ fn can_filter_balance_in_proxy_when_activated() {
 		assert_ok!(Proxy::add_proxy(Origin::signed(1), 2, ProxyType::JustTransfer, 0));
 
 		assert_ok!(Proxy::proxy(Origin::signed(2), 1, None, Box::new(call_transfer())));
-		System::assert_last_event( pallet_proxy::Event::ProxyExecuted { result: Ok(()) }.into() );
-		
+		System::assert_last_event(pallet_proxy::Event::ProxyExecuted { result: Ok(()) }.into());
+
 		assert_ok!(SafeMode::force_activate(ForceActivateOrigin::Weak.signed()));
 
 		assert_ok!(Proxy::proxy(Origin::signed(2), 1, None, Box::new(call_transfer())));
 		System::assert_last_event(
-			pallet_proxy::Event::ProxyExecuted { result:  DispatchError::from(frame_system::Error::<Test>::CallFiltered).into() }.into(),
+			pallet_proxy::Event::ProxyExecuted {
+				result: DispatchError::from(frame_system::Error::<Test>::CallFiltered).into(),
+			}
+			.into(),
 		);
 	});
 }
@@ -494,4 +497,4 @@ fn fails_when_explicit_origin_required() {
 
 fn call_transfer() -> RuntimeCall {
 	RuntimeCall::Balances(pallet_balances::Call::transfer { dest: 1, value: 1 })
-}
+}
diff --git a/frame/tx-pause/src/tests.rs b/frame/tx-pause/src/tests.rs
@@ -65,6 +65,50 @@ fn can_unpause_specific_call() {
 	});
 }
 
+#[test]
+fn can_filter_balance_in_batch_when_paused() {
+	new_test_ext().execute_with(|| {
+		let batch_call =
+			RuntimeCall::Utility(pallet_utility::Call::batch { calls: vec![call_transfer(1, 1)] });
+
+		assert_ok!(TxPause::pause_call(
+			Origin::signed(mock::PauseOrigin::get()),
+			name(b"Balances"),
+			name(b"transfer"),
+		));
+
+		assert_ok!(batch_call.clone().dispatch(Origin::signed(0)));
+		System::assert_last_event(
+			pallet_utility::Event::BatchInterrupted {
+				index: 0,
+				error: frame_system::Error::<Test>::CallFiltered.into(),
+			}
+			.into(),
+		);
+	});
+}
+
+#[test]
+fn can_filter_balance_in_proxy_when_paused() {
+	new_test_ext().execute_with(|| {
+		assert_ok!(TxPause::pause_call(
+			Origin::signed(mock::PauseOrigin::get()),
+			name(b"Balances"),
+			name(b"transfer"),
+		));
+
+		assert_ok!(Proxy::add_proxy(Origin::signed(1), 2, ProxyType::JustTransfer, 0));
+
+		assert_ok!(Proxy::proxy(Origin::signed(2), 1, None, Box::new(call_transfer(1, 1))));
+		System::assert_last_event(
+			pallet_proxy::Event::ProxyExecuted {
+				result: DispatchError::from(frame_system::Error::<Test>::CallFiltered).into(),
+			}
+			.into(),
+		);
+	});
+}
+
 // GENERAL FAIL/NEGATIVE TESTS ---------------------
 
 #[test]