Update frontend build system to shed old dependencies, and address fallout from that #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsdw
changed the title
|
Ok, so I built the docker image locally (with podman instaed of docker; nice that this worked seamlessly) and it seems to work ok now and the SUBSTRATE_TELEMETRY_URL env var is respected. |
Closed
lexnv
approved these changes
Jan 26, 2023
sergejparity
approved these changes
Jan 27, 2023
Rose2161
pushed a commit
to Cryptob3auty/mtsubstrate-telemen
that referenced
this pull request
Apr 15, 2024
…llout from that (paritytech#521) * get tests working and update copyright headers * lint fix * eslint ts update * update CI to use NPM * fix CI * prettier * npm, not yarn for docker * remove unused package * bump dockerfile to latest node LTS and no need for cache clean * make frontend Dockerfile work and remove unused SUBSTRATE_TELEMETRY_SAMPLE * remove final yarn references * add another comment * remove unused import * remove more unused deps * comment typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly a pass just to bring things uptodate and try to be fairly standard in the libraries we use etc.
I've tested this locally and all seems to work. One thing that would be good to check is that the docker builds still work OK. I think they should be fine but want to be sure that you can still pass in the SUBSTRATE_TELEMETRY_URL properly for instance.