Cap number of nodes allowed to connect for third party networks #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only add a new node if the current number of connected nodes is below the max Define "first party networks" to be: Polkadot, Kusama, Westend and Rococo. All other networks are capped to 500 nodes
dvdplm
commented
Mar 25, 2021
dvdplm
commented
Mar 25, 2021
Comment on lines
+35
to
+38
| set.insert("Polkadot"); | ||
| set.insert("Kusama"); | ||
| set.insert("Westend"); | ||
| set.insert("Rococo"); |
There was a problem hiding this comment.
This needs some vetting. Is that the full list of networks we want to consider "first party"?
There was a problem hiding this comment.
Looks fine to me, at least; we also run Canvas but I think we can ignore that for now. The only one I'm not super sure about is "Local Testnet" but that's well under 500 at the moment so...
TarikGul
reviewed
Mar 25, 2021
| let label: Label = label.into(); | ||
| let cid = self.chains.add_with(|cid| { | ||
| ChainEntry { | ||
| addr: Chain::new(cid, addr, label.clone()).start(), | ||
| label: label.clone(), | ||
| network_id: network.clone(), | ||
| network_id: None, // TODO: this doesn't seem to be used anywhere. Can it be removed? |
There was a problem hiding this comment.
Is network_id still used in the fn handler inside of the impl Handler?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an attempt to stem the flood of nodes connecting to the telemetry server from third party networks this PR caps the maximum number of nodes to 500.