Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functions for incoming multi-stream connections #2982

Merged
merged 2 commits into from
Nov 11, 2022

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Nov 8, 2022

They're unused in practice, but there's no reason to not allow ingoing multi-stream connections in the underlying state machine.

cc #2802

Copy link
Contributor

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approving tomaka's pull requests. This auto-approval will be removed once more maintainers are active.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

twiggy diff report

Difference in .wasm size before and after this pull request.


 Delta Bytes │ Item
─────────────┼──────────────────────────────────────────────────────────────────────────────────────────────────────────
        +777 ┊ smoldot::libp2p::collection::multi_stream::MultiStreamConnectionTask<TNow,TSubId>::new::h0ec5113094ca96e9
        -716 ┊ smoldot::libp2p::collection::multi_stream::MultiStreamConnectionTask<TNow,TSubId>::new::h9c7573e5fb7e11bb
        +392 ┊ smoldot::libp2p::collection::Network<TConn,TNow>::insert_multi_stream::ha6f96bfaae673f10
        -390 ┊ smoldot::libp2p::collection::Network<TConn,TNow>::insert_multi_stream::hadd4facec4179ba9
         +16 ┊ type[67]: (i32, i32, i32, f64, i32, i32, i32, i32, i32, i32, i32, i32, i32) -> nil
         -15 ┊ type[67]: (i32, i32, f64, i32, i32, i32, i32, i32, i32, i32, i32, i32) -> nil
         -10 ┊ type[71]: (i32, i64, i32, f64, i32, i32) -> i64
         +10 ┊ type[72]: (i32, i64, i32, f64, i32, i32) -> i64
         -10 ┊ type[76]: (i32, i32, i32, i32, f64, i32) -> i64
         +10 ┊ type[77]: (i32, i32, i32, i32, f64, i32) -> i64
          +9 ┊ type[71]: (i32, i32, f64, i32, i32, i32) -> nil
          -9 ┊ type[72]: (i32, i32, f64, i32, i32, i64) -> nil
          +9 ┊ type[73]: (i32, i32, f64, i32, i32, i64) -> nil
          -9 ┊ type[78]: (i32, i32, f64, i32, i32, i32) -> nil
          -8 ┊ type[74]: (i32, f64, i32, i32, i32) -> nil
          +8 ┊ type[75]: (i32, f64, i32, i32, i32) -> nil
          -8 ┊ type[75]: (i32, i32, i64, i64, i32) -> nil
          +8 ┊ type[76]: (i32, i32, i64, i64, i32) -> nil
          -8 ┊ type[77]: (i32, i32, i32, f64, i32) -> nil
          +8 ┊ type[78]: (i32, i32, i32, f64, i32) -> nil
          +2 ┊ ... and 3 more.
         +66 ┊ Σ [23 Total Rows]

@tomaka tomaka added the automerge Automatically merge pull request as soon as possible label Nov 11, 2022
@mergify mergify bot merged commit 02f856d into paritytech:main Nov 11, 2022
@tomaka tomaka deleted the add-in-multistream branch November 11, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge pull request as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant