Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repository refactor/restructure/cleanup #72

Merged
merged 29 commits into from
Jul 10, 2019
Merged

Repository refactor/restructure/cleanup #72

merged 29 commits into from
Jul 10, 2019

Conversation

TriplEight
Copy link
Contributor

@TriplEight TriplEight commented Apr 11, 2019 •
edited
Loading

  • restructured dirs, now all CI jobs match the image name and dockerfile's dir
  • added metadata to all images we have
  • optimized CI
  • removed stale dockerfiles
  • optimized layers in build dockerfiles
  • updated README.mds
  • added caching for snap builds
  • some cleanup
  • fixed armhf, arm64, i386 as they didn't inherit from the modern parity-ci-linux image

Please tell me before merging, openethereum/parity-ethereum#10863 should be merged right after this.

@TriplEight TriplEight changed the title Dockerfiles update WIP: Dockerfiles update Apr 11, 2019
@TriplEight TriplEight requested a review from gabreal April 11, 2019 17:38
@General-Beck General-Beck mentioned this pull request Apr 12, 2019
Closed
gabreal
gabreal approved these changes Apr 12, 2019
View reviewed changes
Copy link
Contributor

@gabreal gabreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I haven't tested any of the files.

docker-files-for-Gitlab-CI-rust/cross/i686/Dockerfile Outdated Show resolved Hide resolved
@TriplEight TriplEight mentioned this pull request Jul 8, 2019
Merged
@TriplEight TriplEight changed the title WIP: Dockerfiles update Repository refactor/restructure/cleanup Jul 8, 2019
gabreal
gabreal approved these changes Jul 9, 2019
View reviewed changes
Copy link
Contributor

@gabreal gabreal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's hard to verify those Dockerfiles that were not moved via git as there is no diff available. But looks good to me 👍

.gitlab-ci.yml Outdated Show resolved Hide resolved
.gitlab-ci.yml Outdated Show resolved Hide resolved
@TriplEight TriplEight merged commit ed72914 into master Jul 10, 2019
@General-Beck General-Beck deleted the dockerfiles_update branch March 11, 2020 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@General-Beck General-Beck General-Beck approved these changes

@gabreal gabreal gabreal approved these changes

@devops-parity devops-parity Awaiting requested review from devops-parity

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TriplEight @General-Beck @gabreal