Conversation
ascjones
requested review from
Robbepop and
dvdplm
and removed request for
dvdplm
dvdplm
reviewed
Dec 7, 2020
Contributor
dvdplm
left a comment
dvdplm
left a comment
There was a problem hiding this comment.
LGTM
It would be good to document the available features in the README though. Arguably out of scope, but while you're in there, perhaps?
dvdplm
approved these changes
Dec 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the
serdedependency optional, as per the convention.Integrating into the substrate runtime, we don't want or need a dependency on serde since it will be using SCALE encoding to marshal the metadata from the runtime.