Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2.11.6 #217

Merged
merged 5 commits into from
Nov 20, 2024
Merged

Release v2.11.6 #217

merged 5 commits into from
Nov 20, 2024

Conversation

pkhry
Copy link
Contributor

@pkhry pkhry commented Nov 20, 2024

Description

  • adds #[allow(deprecated)] attribute to the generated code

@pkhry pkhry requested review from jsdw and lexnv November 20, 2024 08:58
Copy link
Contributor

@lexnv lexnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

The ui fail_with_invalid_codec_attrs needs some adjustments, but overall looks good

@jsdw
Copy link
Contributor

jsdw commented Nov 20, 2024

Yup, running TRYBUILD=overwrite cargo test should sort out the failure :)

@pkhry
Copy link
Contributor Author

pkhry commented Nov 20, 2024

Yup, running TRYBUILD=overwrite cargo test should sort out the failure :)

That's what I was doing, for ui tests specifically and I don't get a snapshot mismatch so there's nothing to overwrite. I use the same rustc version as the CI.

@pkhry pkhry merged commit 885a920 into master Nov 20, 2024
2 checks passed
@pkhry pkhry deleted the release-2.11.6 branch November 20, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants