-
Notifications
You must be signed in to change notification settings - Fork 22
add LLVM 18.x as a git submodule #399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
6c7f201 to
ddfb47b
Compare
|
@xermicus now it's good to go |
This changeset is based on paritytech#346
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, very nice! Two things stick out:
- The submodule should only be required in LLVM test and release workflows?
- The
Test LLVM Builderaction doesn't seem being run in this PR. But it should surely have been triggered based on this change set?
| branches: ["main"] | ||
| types: [opened, synchronize] | ||
| paths: | ||
| - 'LLVM.lock' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this should run when the .gitmodules has changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file no longer exists. The way it suppose to work in future is we update new llvm file with new commit to pull from LLVM
.github/workflows/test.yml
Outdated
| with: | ||
| submodules: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, shouldn't be needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let me try to remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh no - the LLVM builder workflow not showing up is due to an invalid spec: https://github.com/paritytech/revive/actions/runs/19039292406
This isn't this PR's fault but would you mind fixing it here at the same time as drive-by?
interesting. The error complain about path and path-ignore, but the structure there didn't change, not sure what happens |
b81b7f3 to
64ceedf
Compare
|
The problem is that we can only have either From my side there is no need to bikeshed this. Just remove I didn't catch this during reviewing the PR introducing the regression. The docs would have explained that but of course I didn't read them careful enough. It's really unfortunate (and also very surprising to me) that in the PR itself there seems to be no indicator whatsoever if there are invalid workflow yml files found 😒 |
This changeset is based on #346