Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

XCM: Replace council XCM origin with general admin #7633

Merged
merged 6 commits into from
Aug 18, 2023
Merged

XCM: Replace council XCM origin with general admin #7633

merged 6 commits into from
Aug 18, 2023

Conversation

KiChjang
Copy link
Contributor

This PR removes the ability to convert a Gov1 council origin to a corresponding Plurality MultiLocation value. In its place, the GeneralAdmin origin can be converted to a Plurality with the BodyId of Adminstration.

@KiChjang KiChjang added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Aug 17, 2023
@paritytech-ci paritytech-ci requested review from a team August 17, 2023 05:47
joepetrowski
joepetrowski approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@joepetrowski joepetrowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think General Admin is necessary (i.e. we don't depend on it in remote locations like we do for Staking Admin), but it seems safe to allow and reasonable that we would use it in remote locations.

@paritytech-ci paritytech-ci requested a review from a team August 17, 2023 07:28
ordian
ordian approved these changes Aug 17, 2023
View reviewed changes
runtime/polkadot/src/xcm_config.rs Outdated Show resolved Hide resolved
@liamaharon
Copy link
Contributor

bot fmt

@command-bot
Copy link

command-bot bot commented Aug 18, 2023 •
edited
Loading

@liamaharon https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3410507 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 49-778a81c1-54ec-45b4-8b5f-5760ef026d5c to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Aug 18, 2023

@liamaharon Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3410507 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3410507/artifacts/download.

@paritytech paritytech deleted a comment from paritytech-processbot bot Aug 18, 2023
@KiChjang
Copy link
Contributor Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 1ef2f8a into master Aug 18, 2023
@paritytech-processbot paritytech-processbot bot deleted the kckyeung/xcm-replace-council-with-general-admin branch August 18, 2023 05:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joepetrowski joepetrowski joepetrowski approved these changes

@liamaharon liamaharon liamaharon approved these changes

@bkchr bkchr bkchr approved these changes

@ordian ordian ordian approved these changes

@franciscoaguirre franciscoaguirre Awaiting requested review from franciscoaguirre

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KiChjang @liamaharon @ordian @bkchr @joepetrowski