Add unapproved count #7179
Add unapproved count #7179
Conversation
kshitjj
force-pushed
the
add-unapproved-count
branch
from
e618352 to
34fda02
Compare
|
The CI pipeline was cancelled due to failure one of the required jobs. |
| s.push(' '); | ||
| } | ||
| let mut unapproved: i32 = 0; | ||
| for (i, bit) in bits.iter().enumerate() { |
There was a problem hiding this comment.
This currently counts the unapproved relay chain blocks. I would still keep this information but add the count of unapproved parachain blocks under the unfinalized relay chain blocks. Also please add a prometheus metric so it is easy to monitor how approval voting performs.
There was a problem hiding this comment.
Hey @sandreim,
I am working on the adding the promotheus metric, but my workstation keeps crashing while building polkadot from source.
Is there a way to run polkadot from source(without building it)?
There was a problem hiding this comment.
Unfortunately you need to build it. What would help is to identify why it is crashing ? OOM ? or you could try building on a separate machine like a cloud VM.
There was a problem hiding this comment.
It's crashing because it's running out of RAM, I am trying to increase the swap. If that doesn't work I will try the virtual machine option.
sandreim
added
the
A3-in_progress
add an unapproved parachain counter, instead of showing bunch of one's.
solves: #7124