Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

some tests to avoid regressions in xcm ancestry inversion #6483

Conversation

dzmitry-lahoda
Copy link

@dzmitry-lahoda dzmitry-lahoda commented Dec 27, 2022

  1. ported some tests from conversion to multilocation
  2. added tests which proves that transferring to and from leads to same location
  3. may be useful to test before merge of Optimize multilocation reanchoring logic in XCM  #6301

@bkchr
Copy link
Member

bkchr commented Dec 27, 2022

Could you point them against the gav-xcmv3 branch?

@dzmitry-lahoda dzmitry-lahoda changed the base branch from master to gav-xcm-v3 December 27, 2022 19:10
@dzmitry-lahoda
Copy link
Author

really nice. interiorml fixed undefined states :) great

@bkchr bkchr requested review from gavofyork and KiChjang December 27, 2022 22:07
@KiChjang
Copy link
Contributor

Should probably go in after we merge XCM v3, otherwise I don't see how this helps with #6301.

@dzmitry-lahoda
Copy link
Author

Sorry for the confusion.

Initially, I was reading ancestry code and found that there are 2 very similar methods for some cases, so different impl. So I ported some cases from one to other. Also added fixed point test (converting back and forth leads to same input).

I PRed to master , same as #6301. So it could be reasonable to run more tests then less on such refactoring to avoid some parachains setup regression.

But. With v3 branch, it seems that v3 has better job to do type safety and code clarity. It is ok to make behaviour change in it, so IMHO #6301 should be rebased on v3 to be more useful.

So these are just tests. And at least one test is readable by ordinary parachain devs (fixed point one).

@paritytech-processbot paritytech-processbot bot deleted the branch paritytech:gav-xcm-v3 January 17, 2023 07:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants