This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
metrics separation #5391
Merged
metrics separation #5391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drahnr
added
B0-silent
ordian
approved these changes
Apr 25, 2022
|
Gladly you left collator-protocol untouched. (I am working on a PR that did the same thing for the collator protocol). |
eskimor
approved these changes
Apr 25, 2022
|
I touched it too much and could not extract the required changeset cleanly 😰 merge conflict upcoming.. |
slumber
approved these changes
Apr 25, 2022
|
bot merge |
|
Waiting for commit status. |
drahnr
added
A8-mergeoncegreen
and removed
A0-please_review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate the metrics definitions in some very old subsystem implementations, that haven't been touch in a while.
Mostly an extraction of #5314 to get that timely merged and avoid merge-pain.